This is the second set of these strap-locks I've purchased. The first I've had for 5 years, and although not heavily gigged, they've stood up to some occasional abuse and are still going strong. The new set are for another guitar. I've tried other types over the years, but for a variety of reasons (freedom of movement, trustworthy construction) these suit me best.
They're not perfect, however - they can be fiddly to fit to thicker straps and occasionally the release mechanism isn't smooth and can take a couple of attempts, also when locking in - it's possible to get it wrong so you learn to check you're properly clicked in. That said - despite this - I trust them with my 2 best guitars, and once fitted and locked in, I'm confident of avoiding that undesirable favourite-guitar-hard-stage interface.